Add comments construct to form generation#276
Open
palagdan wants to merge 2 commits into
Open
Conversation
palagdan
marked this pull request as draft
July 14, 2025 10:58
palagdan
force-pushed
the
comment-model
branch
2 times, most recently
from
October 3, 2025 14:20
8021a0c to
66a258a
Compare
palagdan
marked this pull request as ready for review
October 3, 2025 14:31
Collaborator
Author
|
@blcham It can be merged. It correctly saves comments to the GraphDB. The problem is that the S-Forms component shows the current user's name as the author of the comment instead of the original author. This happens here: https://github.com/kbss-cvut/s-forms/blob/master/src/components/comment/CommentView.jsx#L27C4-L38C6. So it should be fixed there... Steps to simulate the problem:
|
palagdan
force-pushed
the
comment-model
branch
from
October 29, 2025 12:22
adfbddc to
f589667
Compare
palagdan
force-pushed
the
comment-model
branch
from
October 31, 2025 15:15
f589667 to
9958928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolve kbss-cvut/23ava-distribution#165