Update blech_run_process workflow to generate parallel command on-the-fly - #790
Open
abuzarmahmood wants to merge 1 commit into
Open
Update blech_run_process workflow to generate parallel command on-the-fly#790abuzarmahmood wants to merge 1 commit into
abuzarmahmood wants to merge 1 commit into
Conversation
…-fly This change removes the dependency on temp files for parallel processing. Instead of using the pre-generated temp/blech_process_parallel.sh file, the workflow now generates the parallel command dynamically based on: - Electrodes from the layout file - Parameters from the .params file (max_parallel_cpu) This allows more flexible operation - if the number of parallel processes is changed in params, the temp files will no longer have to be updated manually. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
blech_run_processworkflow to no longer use temp files but to generate the parallel command on-the-fly.Changes Made
Modified
blech_run_process.shto:max_parallel_cpuparameter from the.paramsfiletemp/blech_process_parallel.shfileBenefits
This change allows more flexible operation. If the number of parallel processes is changed in params, the temp files will no longer have to be updated manually. The workflow now:
max_parallel_cpuparameter from the params file to determine parallelismTesting
bash -nFixes
Closes #789