Skip to content

Update records.json - #210

Merged
katorly merged 4 commits into
katorlys:mainfrom
muadogmatem:main
Aug 12, 2026
Merged

Update records.json#210
katorly merged 4 commits into
katorlys:mainfrom
muadogmatem:main

Conversation

@muadogmatem

@muadogmatem muadogmatem commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🌐 Website

Link:

Screenshot:

📋 Checklist

  • I have starred the repository.
  • I have read and accepted the Terms of Service.
  • There is reasonable content on my site.
  • I have configured a custom domain for my site.

Summary by CodeRabbit

  • New Features
    • Added support for the lyhoangkhang domain mapping to its Vercel-hosted site.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 58dd6c8d-ee68-4d04-a735-83f7bd2ba750

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa44ac and 5d874f7.

📒 Files selected for processing (1)
  • records.json

📝 Walkthrough

Walkthrough

Added the lyhoangkhang CNAME mapping to lyhoangkhang.vercel.app in records.json.

Changes

CNAME Mapping

Layer / File(s) Summary
Add CNAME mapping
records.json
Adds the lyhoangkhang entry pointing to lyhoangkhang.vercel.app.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: 202420505, plodroid, homelander436-in

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the updated file and matches the pull request change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@records.json`:
- Around line 97-98: Reorder the entries in records.json so the lyhoangkhang key
appears before yixboost, matching the workflow’s sorted-key order while
preserving both values.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5dbe75a6-ceb0-4e8d-bfe6-386d7764a6c8

📥 Commits

Reviewing files that changed from the base of the PR and between 68b68f8 and f3c58f5.

📒 Files selected for processing (1)
  • records.json

Comment thread records.json Outdated
@katorly katorly added the ⚠️Pending: response The application is awaiting the applicant's response. label Aug 12, 2026
@katorly

katorly commented Aug 12, 2026

Copy link
Copy Markdown
Member

Hello! Please accept our Terms of Service by ticking all the boxes first.

What's more, please complete Step 4 in https://github.com/katorlys/rweb.site/wiki/Vercel, and paste the TXT record here.

@katorly

katorly commented Aug 12, 2026

Copy link
Copy Markdown
Member

Please use the TXT record instead of NS records.

image

@katorly

katorly commented Aug 12, 2026

Copy link
Copy Markdown
Member

And as TXT record is a temporary DNS record, you don't have to add it to records.json

@muadogmatem

Copy link
Copy Markdown
Contributor Author

vc-domain-verify=lyhoangkhang.rweb.site,4b2f9d35b12dfec66ce6

@katorly

katorly commented Aug 12, 2026

Copy link
Copy Markdown
Member

Your site is live at lyhoangkhang.rweb.site 🎉

@katorly
katorly merged commit d285d34 into katorlys:main Aug 12, 2026
4 checks passed
@katorly katorly added ✅Approved Application approved. and removed ⚠️Pending: response The application is awaiting the applicant's response. labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅Approved Application approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants