Skip to content

Add new entry for 'xiangstudy' in records.json - #200

Open
reyanshh6 wants to merge 1 commit into
katorlys:mainfrom
reyanshh6:main
Open

Add new entry for 'xiangstudy' in records.json#200
reyanshh6 wants to merge 1 commit into
katorlys:mainfrom
reyanshh6:main

Conversation

@reyanshh6

@reyanshh6 reyanshh6 commented Aug 7, 2026

Copy link
Copy Markdown

🌐 Website

Link:

Screenshot:

📋 Checklist

  • I have starred the repository.
  • I have read and accepted the Terms of Service.
  • There is reasonable content on my site.
  • I have configured a custom domain for my site.

Summary by CodeRabbit

  • New Features
    • Added the xiangstudy domain configuration for site access.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Added the xiangstudy hostname and mapped it to 8168b0ad2ee03fcc.vercel-dns-017.com in records.json.

Changes

CNAME record update

Layer / File(s) Summary
Add xiangstudy CNAME mapping
records.json
The CNAME mapping now includes xiangstudy. The existing yixboost mapping remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: ✅Approved

Suggested reviewers: channel101, rajeev91691, tangjingguang

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the addition of the xiangstudy entry to records.json.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Aug 7, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@records.json`:
- Around line 94-95: Reorder the adjacent records so the "xiangstudy" entry
appears before "yixboost", matching the canonical sort_keys=True ordering used
by the validation workflow.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 28e4a094-d3fb-47a3-9dbe-68f0739b968f

📥 Commits

Reviewing files that changed from the base of the PR and between c0d9899 and 70a8596.

📒 Files selected for processing (1)
  • records.json

Comment thread records.json
Comment on lines +94 to +95
"yixboost": "naslambers.synology.me",
"xiangstudy": "8168b0ad2ee03fcc.vercel-dns-017.com"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Place xiangstudy before yixboost.

.github/workflows/validation.yml rewrites records.json with sort_keys=True. The current order is not canonical. Move "xiangstudy" before "yixboost" to prevent validation from rewriting the file.

Proposed fix
-    "yixboost": "naslambers.synology.me",
-    "xiangstudy": "8168b0ad2ee03fcc.vercel-dns-017.com"
+    "xiangstudy": "8168b0ad2ee03fcc.vercel-dns-017.com",
+    "yixboost": "naslambers.synology.me"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"yixboost": "naslambers.synology.me",
"xiangstudy": "8168b0ad2ee03fcc.vercel-dns-017.com"
"xiangstudy": "8168b0ad2ee03fcc.vercel-dns-017.com",
"yixboost": "naslambers.synology.me"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@records.json` around lines 94 - 95, Reorder the adjacent records so the
"xiangstudy" entry appears before "yixboost", matching the canonical
sort_keys=True ordering used by the validation workflow.

@katorly

katorly commented Aug 7, 2026

Copy link
Copy Markdown
Member

Hello! Please agree to our Terms of Service by ticking all the boxes first.

And, please use Vercel CNAME record instead of NS records.

@katorly katorly added the ⚠️Pending: response The application is awaiting the applicant's response. label Aug 7, 2026
@reyanshh6

Copy link
Copy Markdown
Author

Please accept

@katorly

katorly commented Aug 8, 2026

Copy link
Copy Markdown
Member

A TXT record for verification is also needed by Vercel. Please complete Step 4 in https://github.com/katorlys/rweb.site/wiki/Vercel and paste the TXT record here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚠️Pending: response The application is awaiting the applicant's response.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants