Fix shared background-job test connection cleanup#955
Merged
Conversation
…-websocket-controls
…-websocket-controls
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f9a7b1bfb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kaspernj
force-pushed
the
feat/10512-frontend-websocket-controls
branch
from
July 24, 2026 13:29
4ae734f to
dcd3c82
Compare
kaspernj
force-pushed
the
feat/10512-frontend-websocket-controls
branch
from
July 24, 2026 13:48
dcd3c82 to
f6c5881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #952.
The final #952 head preserved test-owned database connections while background-job main and worker were still active, but never closed them after both stopped. On SQLite this left commit callbacks attached to stale connection state and made the later live-query tests miss record-change notifications.
This keeps both owners alive during shutdown and closes the shared test connections exactly once after both have stopped, independent of stop order.
Validated in Docker:
npm run lint