Optionally increase pop-up timeout as pop-up text length increases#10
Open
krvkir wants to merge 3 commits into
Open
Optionally increase pop-up timeout as pop-up text length increases#10krvkir wants to merge 3 commits into
krvkir wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change adds
timeout-per-tokenvariable. If it is set, oldtimeoutvar is ignored, and timeout is evaluated individually for each response size. This solves the problem with long pop-ups which fade out too quickly.By default new var is set to nil and ignored, constant timeout is used, so old users will not notice any change in behaviour.