feat: light chrome theme (chromeTheme prop) - #34
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
kino | 3aaf6f7 | Commit Preview URL Branch Preview URL |
Jul 23 2026, 12:52 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds light-theme support to kino's player chrome (control bar, captions, idle overlay, scrubber, flash, menus, compact/touch UI) via a new
chromeThemeprop.chromeTheme?: "light" | "dark"(default"dark") onPlayerPropsandScenesPlayerProps. Stampsdata-kino-themeon the.kinoroot.--kino-*tokens. Each token's dark value equals the literal it replaced, so dark chrome is byte-for-byte unchanged. A new.kino[data-kino-theme="light"]block defines light-glass token values (translucent white surfaces, dark text/icons, black-alpha borders/tracks).sceneTheme, which themes the scene stage inside the iframe.chromeThemestyles kino's own chrome in the parent document./themingpage (drives the Scenes tab, the only wrapper that forwardschromeThemetoday).Why
The karnstack app is migrating a full course to the scenes player and needs the player chrome to read correctly in light theme, not just the scene canvas.
Safety
"dark", token dark values verbatim). Verified token-by-token in review.chromeThemeis destructured out before the scenes provider options, so it never leaks intocreateScenesProvider.sceneTheme/theme/accentColoruntouched.data-kino-themeattribute for both explicit light and the dark default. 203/203 pass; format/typecheck/lint/build clean.Changeset: minor.