Skip to content

PR for refactoring some aspects of the code - #3

Open
yusuf1759 wants to merge 8 commits into
masterfrom
dev_yusuf
Open

PR for refactoring some aspects of the code#3
yusuf1759 wants to merge 8 commits into
masterfrom
dev_yusuf

Conversation

@yusuf1759

@yusuf1759 yusuf1759 commented Sep 8, 2020

Copy link
Copy Markdown
Member

I have done a little bit of work refactoring the code base based on the suggestions and comments I got from users. Here are some of the things I did:

  1. Wrote tests for the vscreenml.
  2. Type hinting
  3. Numpy-style docstring
  4. Created a proper VS pipeline, what we had before for per complex prediction pipeline
  5. Centralized all the loose code, all the loose *.py files like parse_binana.py are all gone. Now, there will not be any issues with some missing files.
  6. There were some complaints about exceptions that were not catching anything, those are all fixed now.
  7. And many more

@yusuf1759 yusuf1759 changed the title PR for refactoring some aspect of the code PR for refactoring some aspects of the code Sep 8, 2020
@yusuf1759
yusuf1759 requested a review from pkiruba September 8, 2020 03:30
@pkiruba

pkiruba commented Sep 9, 2020

Copy link
Copy Markdown
Member

@yusuf1759 Please go ahead and merge the PR. Everything seems good. Small check required in the MIT license file which seems to be not working properly.

@linminhtoo

Copy link
Copy Markdown

hi @yusuf1759 will you merge this PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants