fix: PR #2 build-breaking bugs - zip target, JobObjects import, no taskkill on drop - #3
Merged
Conversation
…, drop invalid zip target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2 left 3 build-breaking bugs in its wake:
"zip"bundle target —zipis not a valid Tauri bundle target, so the custom build command fails (exit code 1).AssignProcessToJobObject/CreateJobObjectW/SetInformationJobObjectwere imported fromThreading; they live inJobObjects. Compile error.Managed::droprankill()(taskkill) on natural completion — even after the child exited cleanly, the whole tree was killed, racing the parent's buffered stdout flush (dropping output) and reapingStart-Processchildren that are meant to outlive the run. NowDroponly closes the job handle (KILL_ON_JOB_CLOSE); taskkill never runs.Verified:
cargo checkwith 0 warnings/errors,cargo test1 passed.