build_debs script rewrite to patch versions - #52
Merged
Conversation
Collaborator
|
Welp, it definitely passes testing in the harness when specifically upgrading only |
jinnatar
reviewed
Aug 7, 2026
| } | ||
|
|
||
| cleanup() { | ||
| # A failed cargo-deb invocation must not leave the source checkout modified. |
Collaborator
There was a problem hiding this comment.
Why tho? .. It's an ephemeral throwaway in a sea of Azure, we could just set it ablaze and bask in the warmth.
Member
Author
There was a problem hiding this comment.
mostly just while I was doing dev things and it was a PITA to clean up mess 😄
jinnatar
reviewed
Aug 7, 2026
Collaborator
|
I reckon this is a good enough solution and we should get it out there for 1.11.1 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's only minor crimes here, I'll let the PR Github Actions build prove if it works, I don't have spare machines to test the build on currently... this should pin the dependencies across the packages to avoid the issues described in #29