Cleanup of ArbCall - #214
Merged
Merged
Conversation
The previous version only handled arb_ptr and acb_ptr, it can now handle any type ending in _ptr or _srcptr.
Previously it could return `Vector{<:Integer}`, but giving anything
other than `Vector{Int}` as an argument would return an error when
trying to convert it to `Ref{Int}`. It now just returns `Vector{Int}`.
This reduces the number of warnings about a method being overwritten when running the tests. There are still some occurrences from the use of `fpwrap_error_on_failure_default`, but these seem harder to avoid (since we do need to test that the overwriting does work for that method).
Reorder types based on where they are coming from. Remove deprecated types from Arb that were removed in the transition to Flint.
Using the init_set! constructor to construct a Mag from an Arf required defining arf_struct before mag_struct and Arf before Mag. This made the ordering more confusing than necessary. The mag_init_set in Flint just calls mag_init and arf_get_mag internally, so removing the use of mag_init_set should not have any noticeable performance impact. At worst we lose the benefits that Flint gets from inlining these two together.
Collaborator
Author
|
Seems like changes to the |
There seems to have been some change to how world age is handled that makes the previous versions of the test no longer work. It seems to suffice to just define both versions of the method before using any of them to avoid this issue.
Collaborator
Author
|
Now it seems to be working! |
kalmarek
approved these changes
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When preparing for the addition on
NFLoatin #202 I had to make several larger changes to the implementation of the low level interface in ArbCall. Some of these changes are general improvements and not directly related to the addition ofNFloat. None of the changes should lead to any changes for users, it mainly cleans up and refactors some of the code. The commits are mostly self contained and the commit messages describe the motivation for the changes, so I'll just refer any interested reader to those.