Skip to content

Keep unsupported runner dry-runs inspectable - #422

Merged
s-hiraoku merged 1 commit into
mainfrom
codex/runner-dry-run-followup
Aug 27, 2026
Merged

Keep unsupported runner dry-runs inspectable#422
s-hiraoku merged 1 commit into
mainfrom
codex/runner-dry-run-followup

Conversation

@s-hiraoku

Copy link
Copy Markdown
Collaborator

Follow-up to #419 and the Phase 1 work tracked in #418.

Summary

  • allow fleet dry-runs to inspect migration plans when the configured runner is not locally supported
  • keep enabled and schedulerSynced false for those inspect-only plans
  • retain fail-closed runner preflight for real scheduler synchronization
  • add regression coverage proving dry-run does not mutate config or registry

Verification

  • npm test -- --run test/fleet.test.ts (33 passed)
  • npm run typecheck
  • npm run check:dist
  • git diff --check

Refs #418

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 21 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: kaizen-agents-org/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1198d436-f52b-457e-88c3-7723b05439b2

📥 Commits

Reviewing files that changed from the base of the PR and between 5a15cab and 49ff5c3.

⛔ Files ignored due to path filters (2)
  • dist/commands/fleet.js is excluded by !**/dist/**
  • dist/commands/fleet.js.map is excluded by !**/dist/**, !**/*.map
📒 Files selected for processing (2)
  • src/commands/fleet.ts
  • test/fleet.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@s-hiraoku

Copy link
Copy Markdown
Collaborator Author

@codex review

@s-hiraoku

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 49ff5c3de4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@s-hiraoku

Copy link
Copy Markdown
Collaborator Author

Autopilot verification complete for current head 49ff5c3de41dd832a8d5cf92d1b668c5840fc480.

  • local: fleet regression 33 passed; typecheck, dist check, diff check passed
  • CI: verify and native-publication-broker passed
  • Codex: current-head review found no major issues
  • review threads: 0 unresolved
  • GitHub: CLEAN / MERGEABLE
  • stabilization: unchanged across two snapshots 30+ seconds apart

CodeRabbit is temporarily rate-limited; its status check is successful and no thread was created. This PR is merge-ready. No merge or auto-merge was performed.

@s-hiraoku
s-hiraoku merged commit 63e7aca into main Aug 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant