fix: normalize Apple .p8 EC key PEM header/footer on load#38
Merged
Conversation
Apple provides EC private keys in PKCS#8 PEM format (-----BEGIN PRIVATE KEY-----). The raw key bytes passed directly to jwt.encode() can fail in some PyJWT or cryptography releases due to sensitivity to the exact PEM header/footer wording or encoding. Add a _load_ec_key() helper that loads the key through cryptography's load_pem_private_key() — which handles both PKCS#8 and SEC1/EC PEM formats transparently — and re-serialises it to a consistent PKCS#8 PEM byte string before handing it to PyJWT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple provides EC private keys in PKCS#8 PEM format (-----BEGIN PRIVATE KEY-----). The raw key bytes passed directly to jwt.encode() can fail in some PyJWT or cryptography releases due to sensitivity to the exact PEM header/footer wording or encoding.
Add a _load_ec_key() helper that loads the key through cryptography's load_pem_private_key() — which handles both PKCS#8 and SEC1/EC PEM formats transparently — and re-serialises it to a consistent PKCS#8 PEM byte string before handing it to PyJWT.