refactor: improve device activity polling with exponential backoff#35
Merged
Conversation
Replace the linear polling in `_wait_for_device_activity_completion` with exponential backoff and extract magic numbers into parameters. - Remove unconditional 10s sleep before the first status check - Switch from linear `10 * (retry + 1)` to exponential `2 ** (retry + 1)` backoff: 2s → 4s → 8s → 16s → 32s (62s total, down from 150s) - Add `backoff_factor` and `max_retries` keyword parameters with sensible defaults for configurability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the linear polling in
_wait_for_device_activity_completionwith exponential backoff and extract magic numbers into parameters.10 * (retry + 1)to exponential2 ** (retry + 1)backoff: 2s → 4s → 8s → 16s → 32s (62s total, down from 150s)backoff_factorandmax_retrieskeyword parameters with sensible defaults for configurability