Record the M3.10c delivery, its margin, and a rule about guards - #179
Merged
Conversation
…ut guards M3.10c merged by rebase across `0563dab` through `5f6f70a`. PR run 32038739390 on head `ea7f916` passed the complete hosted matrix. The margin is about eleven minutes: the slowest job moved from 9m21s to 8m48s while the slice removed six translation units and added ten plus a fuzz target, which is inside the run-to-run variance and says the exchange was roughly even. `docs/engineering/verification.md` gains a Guards section, because this slice found the same defect M3.7a found and one block later in the same file. A guard's subject is the gate rather than the protocol, so the failure it catches is silent and nothing notices when the guard itself stops working. Two rules: run a guard against the omission it exists to catch and see it fail, because the repository passed before the guard was written; and assert what a CMake parse reached, because both defects so far are a pattern that ran past a block nested inside `if(...)` and found the name it was asked to notice was missing. The next action is M3.10d, the fourteen transitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeout for #177 / PR #178, which merged by rebase across
0563dabthrough5f6f70a. Documentation only — the lightweight metadata path is the risk-proportionate gate.What it records
ea7f916passed the complete hosted matrix; the post-merge run onmainis recorded once terminal.clang-sanitizersis still the slowest and is the only preset that builds the fuzz targets, so it is where M3.10d's transitions will show first.docs/engineering/verification.md. This slice found the same defect M3.7a found, one block later in the same file: a pattern anchored to a closing paren in column zero does not terminate at a block nested insideif(...), runs on, and finds the name it was asked to notice was missing. Twice is a rule.Two rules, and both come from a defect rather than from principle:
PROTOCOL_STACK_TARGETSentirely.CMakeLists.txtmust assert what its pattern reached, so a pattern that swallowed the file fails rather than passes.Verification
python3 tools/verify_metadata.py— 5 skills and 212 internal Markdown links validated.python3 -m unittest discover -s tests/tools -p '*_test.py'— 19 tests, OK.