Redesign library UI: single toolbar, popover filters, faster cards - #44
Merged
Conversation
- Collapse the two control rows into one toolbar; move status/confidence/type filters into a Filter popover with an active-count badge, and sort/layout/browse mode into a View popover - Remove the per-card drop-shadow effect in favor of border-based depth to fix scroll lag - Slim the button tiers and add toolbar/segmented/icon/popover style helpers - Rebuild the details panel with status chips, an interactive star rating, and tag chips (new widgets/controls.py) - Accent-tint the scrollbar on hover
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Comment on lines
+120
to
+121
| value = (i + 1) * 2 | ||
| btn.clicked.connect(lambda _=False, v=value: self._on_click(v)) |
There was a problem hiding this comment.
When users edit a rating from the redesigned details panel, each star is wired to (i + 1) * 2, so this control can only save 2/4/6/8/10. The Game.rating model and the previous details combo supported every value from 1 through 10, and the card context menu still exposes odd ratings, so users can no longer set or adjust odd ratings from the main details editor. Consider supporting half-star/alternate clicks or another picker path for all 1–10 values.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A full visual overhaul of the library UI focused on decluttering the control surface, reducing button bulk, and fixing scroll lag.
Scan · Updates · [segmented quick-filters] … Filter · View · [icon toggles].QGraphicsDropShadowEffectthat thrashed with the entrance-fade and forced off-screen rendering on every scroll. Depth now comes from border/background tokens.toolbar_btn_style,segmented_btn_style,icon_btn_style, andpopover_frame_stylehelpers.widgets/controls.py). Theshow_game/apply_edits_to_gamepersistence contract is preserved.Verification
pytest— 282 tests pass.MainWindowconstructs cleanly.