- Fixed codestyle c++ action by kadeshar · Pull Request #40 · kadeshar/mod-playerbots

kadeshar · 2025-11-01T22:16:34Z

No description provided.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull Request Overview

Copilot reviewed 52 out of 58 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 106 out of 112 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 126 out of 140 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-02T14:04:46Z

 {
    ObjectGuid::LowType owner = player->GetGUID().GetCounter();
-    if (victim->GetTypeId() != TYPEID_UNIT)
+    if (victim->IsCreature())


Logic error: the function returns early if the victim IS a creature, but then tries to cast it to Creature*. This should be if (!victim->IsCreature()) to check if the victim is NOT a creature.

Suggested change

if (victim->IsCreature())

if (!victim->IsCreature())

Copilot

Pull Request Overview

Copilot reviewed 132 out of 145 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T16:55:00Z

    bot->AddSpellCooldown(spellId, 0, 3 * 60 * 1000);
    return true;
-}
+}


Missing newline at end of file. The file should end with a newline character according to POSIX standards and most C++ style guides.

Copilot

Pull Request Overview

Copilot reviewed 133 out of 147 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T17:10:15Z

 {
    ObjectGuid::LowType owner = player->GetGUID().GetCounter();
-    if (victim->GetTypeId() != TYPEID_UNIT)
+    if (victim->IsCreature())


The logic appears to be inverted. The original code checked if (victim->GetTypeId() != TYPEID_UNIT) which returned early if the victim was NOT a unit. The new code with IsCreature() returns early if the victim IS a creature, which is the opposite behavior. This should be if (!victim->IsCreature()).

Suggested change

if (victim->IsCreature())

if (!victim->IsCreature())

Copilot · 2025-11-04T17:10:16Z

-    WorldObject const* i_obj;
-    float i_range;
-};
+#include "NearestGameObjects.h"


The entire AnyGameObjectInObjectRangeCheck class definition (lines 15-31 in the original) has been removed and replaced with an include of 'NearestGameObjects.h'. Ensure that this header file exists and contains the required AnyGameObjectInObjectRangeCheck class definition, as this file likely depends on it.

Copilot

Pull Request Overview

Copilot reviewed 134 out of 148 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T17:33:00Z

 #include "Event.h"
 #include "GridNotifiers.h"
 #include "GridNotifiersImpl.h"
+#include "NearestGameObjects.h"


The addition of this include suggests a new header file 'NearestGameObjects.h' was created to contain the AnyGameObjectInObjectRangeCheck class that was removed from this file (lines 58-76 deleted) and RevealGatheringItemAction.cpp. However, this header file is not present in the diff. Please ensure NearestGameObjects.h exists and contains the relocated class definition.

Copilot

Pull Request Overview

Copilot reviewed 133 out of 149 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-05T15:08:13Z

 #include "Event.h"
 #include "GridNotifiers.h"
 #include "GridNotifiersImpl.h"
+#include "NearestGameObjects.h"


A new header file 'NearestGameObjects.h' is included, presumably to provide the AnyGameObjectInObjectRangeCheck class that was previously defined inline. Ensure this header file exists and contains the necessary class definition.

Copilot · 2025-11-05T15:08:13Z

-    WorldObject const* i_obj;
-    float i_range;
-};
+#include "NearestGameObjects.h"


A new header file 'NearestGameObjects.h' is included to replace the inline class definition. Ensure this header file exists and contains the AnyGameObjectInObjectRangeCheck class definition that was removed from this file.

- Fixed codestyle c++ action

8960cc6

Copilot AI review requested due to automatic review settings November 1, 2025 22:16

kadeshar added 3 commits November 1, 2025 23:21

- Action trigger

cd91181

- Fixed auto const& codestyle

528f8be

- More codestyle fixes

fbb25d2

Copilot AI reviewed Nov 1, 2025

kadeshar added 2 commits November 1, 2025 23:49

- More codestyle fixes

2022317

- Mode codestyle fixes

ddef27d

Copilot AI review requested due to automatic review settings November 2, 2025 13:11

Copilot AI reviewed Nov 2, 2025

View reviewed changes

kadeshar added 2 commits November 2, 2025 14:22

- More codestyle fixes

89446d1

- More codestyle fixes

c3c1bf6

Copilot AI review requested due to automatic review settings November 2, 2025 13:37

Copilot AI reviewed Nov 2, 2025

View reviewed changes

- More codestyle fixes

3875807

kadeshar requested a review from Copilot November 2, 2025 14:02

Copilot AI reviewed Nov 2, 2025

View reviewed changes

kadeshar added 2 commits November 4, 2025 17:51

- More codestyle fixes

747b662

- More codestyle fixes

c443ff6

Copilot AI review requested due to automatic review settings November 4, 2025 16:53

Copilot AI reviewed Nov 4, 2025

View reviewed changes

kadeshar added 2 commits November 4, 2025 17:58

- Action fix

e613337

- More codestyle fixes

c6f9be3

Copilot AI review requested due to automatic review settings November 4, 2025 17:08

Copilot AI reviewed Nov 4, 2025

View reviewed changes

kadeshar added 2 commits November 4, 2025 18:17

- More codestyle fixes

0c6a5eb

- Added unknownMacro positive false suppresion

ad49e47

Copilot AI review requested due to automatic review settings November 4, 2025 17:31

Copilot AI reviewed Nov 4, 2025

View reviewed changes

- Merge

44ab222

- Gruuls helper codestyle fix

f0e0b0a

Copilot AI review requested due to automatic review settings November 5, 2025 15:05

- Fixed codestyle

c7bc792

Copilot AI reviewed Nov 5, 2025

View reviewed changes

kadeshar closed this Nov 6, 2025

kadeshar deleted the codestyle-fix branch March 22, 2026 12:17

Conversation

kadeshar commented Nov 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants