Repository navigation
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the Eternal Belt Buckle mechanic from WotLK, which adds a prismatic socket to belts. The changes enable bots to automatically apply belt buckles and socket gems into the prismatic slot.
Key changes:
- Added belt buckle application logic in the PlayerbotFactory to automatically equip belt buckles during bot setup
- Enhanced gem socketing logic to support prismatic sockets created by belt buckles
- Updated enchantment and gem selection algorithms to handle the additional prismatic socket slot
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/strategy/actions/UseItemAction.cpp | Adds prismatic socket support to the SocketItem function, enabling gems to be placed in belt buckle slots |
| src/factory/PlayerbotFactory.cpp | Implements belt buckle application logic and extends gem assignment to include prismatic slots |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| nicePacket.Read(); | ||
| bot->GetSession()->HandleSocketOpcode(nicePacket); | ||
|
|
||
| return true; |
There was a problem hiding this comment.
Inconsistent indentation: this line uses tabs while the rest of the file uses spaces. Replace the tab with 8 spaces to match the surrounding code style.
| return true; | |
| return true; |
| // Does the belt have an active "buckle" (prismatic hunt)? | ||
| const bool hasPrismaticBeltSocket = | ||
| item->GetEnchantmentId(PRISMATIC_ENCHANTMENT_SLOT) == ENCHANT_SOCKET_BELT; |
There was a problem hiding this comment.
The variable hasPrismaticBeltSocket is declared but never used. The same check is performed again at line 398. Either remove this unused variable or refactor the code at line 398 to use it.
| WorldPacket packet(CMSG_SOCKET_GEMS); | ||
| packet << item->GetGUID(); | ||
|
|
||
| // Does the belt have an active "buckle" (prismatic hunt)? |
There was a problem hiding this comment.
Corrected 'hunt' to 'slot' in the comment. The term 'prismatic hunt' appears to be a typo; it should likely read 'prismatic slot'.
| // Does the belt have an active "buckle" (prismatic hunt)? | |
| // Does the belt have an active "buckle" (prismatic slot)? |
| namespace | ||
| { | ||
| // WotLK Eternal Belt Buckle mechanics | ||
| constexpr uint32 ITEM_ETERNAL_BELT_BUCKLE = 41611; // Eternal Belt Buckle (consommable) |
There was a problem hiding this comment.
Corrected spelling of 'consommable' to 'consumable'.
| constexpr uint32 ITEM_ETERNAL_BELT_BUCKLE = 41611; // Eternal Belt Buckle (consommable) | |
| constexpr uint32 ITEM_ETERNAL_BELT_BUCKLE = 41611; // Eternal Belt Buckle (consumable) |
Warning: Dont change this PR as draft to make it testable DONT REVIEW UNTIL Codestyle C++ workflow dont pass
No description provided.