Repository navigation
test(build): resolve fsSafe.js to its real source in the packaging check - #162
Merged
Merged
Conversation
STR-01 ships the app's own src/main/fsSafe.js into .frame/bin/, while the build.files check from #160 assumed every copied file comes from scripts/. Both PRs were green on their own; together the check reported a missing scripts/fsSafe.js. The file is packaged through src/**/*, so only the check's source mapping was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After merging #160 and #161,
test/buildFiles.test.jsfails onmain:STR-01 (#161) ships the app's own
src/main/fsSafe.jsinto.frame/bin/, but the packaging check from #160 assumed every copied file comes fromscripts/. Each PR was green on its own; the failure only appears once both are merged.Fix
The check maps
fsSafe.jsto its real source,src/main/fsSafe.js, whichsrc/**/*already packages. No packaging change is needed.Verification
npm test: 978/978 passing.