Repository navigation
ci: generate CREDITS with gocredits v1.0.0 from a make target - #83
Merged
Merged
Conversation
prerelease_for_tagpr runs gocredits, but it does not depend on depsdev and the tagpr workflow does not install gocredits either, so the command is not found on the runner and CREDITS has never been created. The calls were also written as "gocredits . -w" and "gocredits . w". The flag after the directory is not parsed, so even an installed gocredits would only have printed to stdout. The credits target installs gocredits pinned to v1.0.0 and writes CREDITS itself, and both prerelease and prerelease_for_tagpr call it, so the two paths write the same file. depsdev no longer installs gocredits because the credits target does.
Contributor
Code Metrics Report
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prerelease_for_tagprruns gocredits, but neither it nor the tagpr workflow installs it, so CREDITS has never been created in this repository. The logs of past tagpr runs have expired, so this comes from reading the Makefile and workflow. The existing calls (gocredits . -w/gocredits . w) also put the flag after the directory, where it is ignored, so the file would not have been written even with gocredits installed.creditstarget now installs gocredits pinned to v1.0.0 and writes CREDITS, and bothprereleaseandprerelease_for_tagprcall it. This follows k1LoW/octocov@c919651.-skip-missingis not used. donegroup has no dependencies today, and a future one without a readable license should makemake creditsfail instead of dropping out of CREDITS silently.CREDITS is not added here. The next release pull request creates it (only the Go license for now).