Warn on non-CRLF line endings in ADIF multiline fields - #6
Merged
Conversation
Copilot created this pull request from a session on behalf of
xylo04
June 5, 2026 23:30
View session
xylo04
marked this pull request as ready for review
June 5, 2026 23:30
xylo04
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADIF
MultilineStringfields must use CRLF for embedded line endings per spec section III.A. The checker now flags lone CR/LF in:Mfields as warnings while continuing normal validation.Validation path
validateADIFWithWarnings) that preserves existing fatal validation behavior.validateADIFas the error-only wrapper to avoid changing existing call semantics.Multiline line-ending checks (
:Monly)\rnot followed by\n\n\r\nsequences without warning.CLI output behavior
mainnow prints accumulated warnings tostderr.Coverage/docs
Mfields (no warning).