Feat/add logging interface#137
Open
ivanleomk wants to merge 5 commits into
Open
Conversation
- Add BaseClusterLogger abstract base class with 8 methods: - 4 standard logging methods: info(), debug(), warning(), error() - 4 clustering methods: log_params(), log_metrics(), log_errors(), log() - Add StandardLogger implementation using Python's logging module - Export StandardLogger in kura.__init__.py - Add demo script log.py showing all functionality - Clean implementation based off main branch
- Add abstract log_artifact method to BaseClusterLogger (9 methods total now) - StandardLogger implements log_artifact as pass (no-op for basic logger) - Updated demo script to test artifact logging - Allows future logger implementations to handle file artifacts properly
…This file is no longer needed as it has been previously marked for removal.
Deploying kura with
|
| Latest commit: |
ced5e5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18d811a0.kura-4ma.pages.dev |
| Branch Preview URL: | https://feat-add-logging-interface.kura-4ma.pages.dev |
jxnl
requested changes
Jun 18, 2025
jxnl
left a comment
jxnl
left a comment
Owner
There was a problem hiding this comment.
don't do this, just log.info and use extras
then implement log handlers instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Introduces a new logging interface for clustering with
BaseClusterLoggerandStandardLogger, and updates dependencies inuv.lock.BaseClusterLoggerinbase_classes/logger.pyas an abstract base class for logging clustering experiments.StandardLoggerinlogger.pyusing Python's standard logging.BaseClusterLoggerdefines methods:info,debug,warning,error,log_params,log_metrics,log_errors,log,log_artifact.StandardLoggerprovides concrete implementations for these methods.StandardLoggerto__init__.pyinkura.BaseClusterLoggerto__init__.pyinbase_classes.uv.lockto includecohere,fastavro,httpx-sse,types-requests.This description was created by
for ced5e5e. You can customize this summary. It will automatically update as commits are pushed.