MeshCorners (crnr), MeshEdges (edge), and UnknownText (uktx)#18
Draft
Rezmason wants to merge 1 commit into
Draft
MeshCorners (crnr), MeshEdges (edge), and UnknownText (uktx)#18Rezmason wants to merge 1 commit into
Rezmason wants to merge 1 commit into
Conversation
…) and UnknownText (uktx)
Owner
|
To make it easier to convert 3DMF to other formats, you may want to convert Mesh geometries to TriMesh form, using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi stranger!
I'm using
Textify3DMFto hopefully convert some old 3DMF files from binary to text, and eventually to GLB for my personal use. The latest version of the tool reports that it doesn't handlecrnroruktx, which are all over my files.Using this useful but incorrectly named reference of the format, I learned of
MeshCorners,UnknownText, andMeshEdges(edge). So I've added support for these in a branch, and my build now successfully handles these types.That said, I haven't put any data length checks into
MeshCornersorMeshEdges, and I have noMeshEdgesof my own to test. All in all, this is a draft PR to hand off what I did to you in case you want it.Have a wonderful day!