Switch to a tail-call based dispatch loop instead of switch-inside-while - #5
Open
jwmerrill wants to merge 18 commits into
Open
Switch to a tail-call based dispatch loop instead of switch-inside-while#5jwmerrill wants to merge 18 commits into
jwmerrill wants to merge 18 commits into
Conversation
These each tail call the "dispatch" function, which reads an instruction and then tail calls the appropriate instruction handler. Inspired by https://blog.reverberate.org/2021/04/21/musttail-efficient-interpreters.html
...instead of reading/mutating it from currentFrame in instruction handlers. Currently syncing it to currentFrame at the start of each dispatch, but I think we can adjust to only doing that syncing when we push new call frames.
Owner
Author
|
Benchmark results at various stages of this work: |
Owner
Author
|
This is a big performance improvement across all benchmarks, but for some reason, clox from the crafting interpreters book is still faster on most benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://blog.reverberate.org/2021/04/21/musttail-efficient-interpreters.html
Unfortunately, the Zig compiler doesn't yet support tail calls when targeting WASM, so merging this would break WASM support.