Repository navigation
[BUGFIX] Provide request for links in info window content - #380
Merged
Merged
Conversation
Set $GLOBALS['TYPO3_REQUEST'] while rendering the info window content view. f:transform.html resolves links via LinkFactory::createUri() without a ContentObjectRenderer, which falls back to the global request. Within a middleware this global is not set yet, so rendering internal page links failed with a TypeError. The previous value is restored after rendering. This is a temporary workaround until a switch to f:format.html can be evaluated with TYPO3 15. Resolves: #379 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
$GLOBALS['TYPO3_REQUEST']while rendering the info window content view.f:transform.htmlresolves links viaLinkFactory::createUri()without aContentObjectRenderer, which falls back to the global request. WithinGetInfoWindowContentMiddlewarethis global is not set yet (it is set inRequestHandlerafter all middlewares), so rendering internal page links failed with aTypeError.The previous value is restored after rendering. This is a temporary workaround: switching to
f:format.htmlwould change the rendering for existing installations and should be evaluated with the TYPO3 15 major release (see ToDo in code).Resolves: #379
🤖 Generated with Claude Code