Repository navigation
Conversation
The site setting maps2.infoWindowContent.templatePath defaulted to Templates/InfoWindowContent.html, which no longer exists since the templates were renamed to *.fluid.html. Info windows failed to render unless a site overrode the path. The partial rendered editorial content with f:transform.html. Its link resolution reads $GLOBALS['TYPO3_REQUEST'], which is not set while GetInfoWindowContentMiddleware renders the view. f:format.html takes the request from the rendering context instead.
morja
force-pushed
the
bugfix/info-window-content-typo3-14
branch
from
September 10, 2026 09:54
a13e051 to
fed3d06
Compare
Contributor
|
Hi @morja thank you for providing a PR for this. Using f:format.html will parse content through lib.parseFunc_RTE which results into a complete different rendering and may break the rendering of a lot of sites out there. I temporary set TYPO3_REQUEST now and left a comment in middleware to check for f:format.html in future (next major release). Stefan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On TYPO3 14 with maps2 13.1.0, clicking a marker does not render the info window.
maps2.infoWindowContent.templatePathdefaults toEXT:maps2/Resources/Private/Templates/InfoWindowContent.html. Since thetemplates were renamed, only
InfoWindowContent.fluid.htmlexists, so the viewcannot find its template unless a site overrides the setting.
Partials/InfoWindowContent.fluid.htmlrenders the editorial content withf:transform.html. Resolvingt3://links there goes throughLinkFactory,which reads
$GLOBALS['TYPO3_REQUEST']. That global is not set whileGetInfoWindowContentMiddlewarerenders the view, so POIs whose content containsa link fail.
Fix
InfoWindowContent.fluid.html.f:format.html. It takes the request from the Fluidrendering context, which
InfoWindowContentService::createView()already passes,and parses the content with
lib.parseFunc_RTElike other RTE output.without the path fix.
Testing
uses maps2 13.1.0.
🤖 Generated with Claude Code