Feature/meta data placement

.github/workflows/ter-release.yml

@@ -0,0 +1,56 @@
+name: ter-release.yml
+
+on:
+  release:
+    types: [published]
+
+permissions:
+  contents: read
+
+jobs:
+
+  publish:
+    name: Publish Extension to TYPO3 Extension Repository (TER)
+    runs-on: ubuntu-latest
+
+    env:
+      TYPO3_EXTENSION_KEY: ${{ secrets.TYPO3_EXTENSION_KEY }}
+      TYPO3_REPOSITORY_URL: ${{ secrets.TYPO3_REPOSITORY_URL }}
+      TYPO3_API_TOKEN: ${{ secrets.TYPO3_API_TOKEN }}
+      TYPO3_API_USERNAME: ${{ secrets.TYPO3_API_USERNAME }}
+      TYPO3_API_PASSWORD: ${{ secrets.TYPO3_API_PASSWORD }}
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+
+      - name: Get version and description
+        id: prep
+        run: |
+          # 1. Clean the version tag (removes 'v' prefix if present, e.g., v1.0.0 -> 1.0.0)
+          RAW_VERSION="${{ github.event.release.tag_name }}"
+          VERSION=${RAW_VERSION#v}
+          echo "VERSION=$VERSION" >> "$GITHUB_OUTPUT"
+
+          # 2. Safely capture the multi-line release body as an ENV variable
+          echo "RELEASE_NOTES<<EOF" >> $GITHUB_ENV
+          echo "${{ github.event.release.body }}" >> $GITHUB_ENV
+          echo "EOF" >> $GITHUB_ENV
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.3'
+          extensions: intl, mbstring, json, libxml, xml, zip, curl
+          tools: composer:v2
+
+      - name: Install TYPO3 Tailor Extension
+        run: composer global require typo3/tailor --prefer-dist --no-progress --no-suggest
+
+      - name: Release to TER
+        run: |
+          # Use the VERSION from steps and RELEASE_NOTES from env
+          # We use double quotes around env.RELEASE_NOTES to handle the multi-line content
+          php ~/.composer/vendor/bin/tailor ter:publish ${{ steps.prep.outputs.VERSION }} \
+            --artefact=${{ env.TYPO3_REPOSITORY_URL }}/archive/${{ github.event.release.tag_name }}.zip \
+            --comment="${{ env.RELEASE_NOTES }}"

Build/phpunit/UnitTestsBootstrap.php

@@ -56,7 +56,7 @@
 
     // We can use the "typo3/cms-composer-installers" constant "TYPO3_COMPOSER_MODE" to determine composer mode.
     // This should be always true except for TYPO3 mono repository.
-    $composerMode = defined('TYPO3_COMPOSER_MODE') && TYPO3_COMPOSER_MODE === true;
+    $composerMode = defined('TYPO3_COMPOSER_MODE') && TYPO3_COMPOSER_MODE;
 
     // @todo: Remove else branch when dropping support for v12
     $hasConsolidatedHttpEntryPoint = class_exists(CoreHttpApplication::class);

Classes/Command/CacheQueryCommand.php

@@ -116,7 +116,7 @@ protected function getCache(string $cacheIdentifier): ?FrontendInterface
     {
         try {
             $cache = $this->getCacheManager()->getCache($cacheIdentifier);
-        } catch (NoSuchCacheException $noSuchCacheException) {
+        } catch (NoSuchCacheException) {
             return null;
         }
 

Classes/Command/ConvertPlainPasswordToHashCommand.php

@@ -78,7 +78,7 @@ protected function updateUsers(string $mode): void
         $counter = 0;
         $connection = $this->getConnectionPool()->getConnectionForTable($this->modeMapping[$mode]['table']);
         $statement = $this->getQueryResultForUsers($this->modeMapping[$mode]['table']);
-        while ($user = $statement->fetch()) {
+        while ($user = $statement->fetchAssociative()) {
             if (!isset($user['password']) || $user['password'] === '') {
                 continue;
             }
@@ -93,7 +93,7 @@ protected function updateUsers(string $mode): void
                     'Password for User ' . $user['uid'] . ' was not updated. Password already hashed.',
                     OutputInterface::VERBOSITY_VERBOSE,
                 );
-            } catch (InvalidPasswordHashException $e) {
+            } catch (InvalidPasswordHashException) {
                 // Perfect. No HashInstance can process this user password. Start update
                 $connection->update(
                     $this->modeMapping[$mode]['table'],
@@ -134,7 +134,7 @@ protected function getNewHashedPassword(string $password, string $mode): string
             OutputInterface::VERBOSITY_VERBOSE,
         );
         $this->output->writeln(
-            '--> Hashed password will be stored (Hash shortened): ' . substr($newPassword, 0, 10),
+            '--> Hashed password will be stored (Hash shortened): ' . substr((string)$newPassword, 0, 10),
             OutputInterface::VERBOSITY_DEBUG,
         );
         return $newPassword;

Classes/Command/StatusReportCommand.php

@@ -111,7 +111,7 @@ protected function checkDatabaseStatus(): void
         $response->getBody()->rewind();
         $json = $response->getBody()->getContents();
 
-        $result = json_decode($json, true);
+        $result = json_decode($json, true, 512, JSON_THROW_ON_ERROR);
 
         $hasSuggestions = isset($result['suggestions']) && $result['suggestions'] !== ''
             ? '<error>YES</error>'

Classes/ContextMenu/ItemProviders/UpdateFileMetaDataProvider.php

@@ -12,6 +12,7 @@
 namespace JWeiland\Jwtools2\ContextMenu\ItemProviders;
 
 use TYPO3\CMS\Core\Resource\File;
+use TYPO3\CMS\Core\Resource\FileType;
 use TYPO3\CMS\Filelist\ContextMenu\ItemProviders\FileProvider;
 
 /**
@@ -59,7 +60,7 @@ protected function canUpdateFile(): bool
     {
         if ($this->record instanceof File) {
             // Do not use $this->record->isImage() as this is also true for SVG and PDF
-            return $this->record->getType() === $this->record::FILETYPE_IMAGE;
+            return $this->record->getType() === FileType::IMAGE->value;
         }
 
         return false;

Classes/Controller/Ajax/AjaxSolrController.php

@@ -88,7 +88,7 @@ public function createIndexQueueAction(ServerRequest $request): ResponseInterfac
                             $site,
                             $indexingConfigurationName,
                         );
-                } catch (ConnectionException|Exception $e) {
+                } catch (ConnectionException|Exception) {
                 }
             }
 

Classes/Controller/Ajax/SysFileController.php

@@ -31,15 +31,10 @@
  */
 class SysFileController
 {
-    protected ResourceFactory $resourceFactory;
-
-    protected GraphicalFunctions $graphicalFunctions;
-
-    public function __construct(ResourceFactory $resourceFactory, GraphicalFunctions $graphicalFunctions)
-    {
-        $this->resourceFactory = $resourceFactory;
-        $this->graphicalFunctions = $graphicalFunctions;
-    }
+    public function __construct(
+        protected ResourceFactory $resourceFactory,
+        protected GraphicalFunctions $graphicalFunctions,
+    ) {}
 
     public function updateFileMetadataAction(ServerRequestInterface $request): JsonResponse
     {
@@ -116,8 +111,8 @@ protected function getValidatedFiles(ServerRequestInterface $request): array
         $validatedFiles = [];
         $files = $request->getQueryParams()['CB']['files'] ?? [];
         foreach ($files as $hash => $file) {
-            [$table, $hash] = explode('|', $hash);
-            if ($table === '_FILE' && $hash === substr(md5($file), 0, 10)) {
+            [$table, $hash] = explode('|', (string)$hash);
+            if ($table === '_FILE' && $hash === substr(md5((string)$file), 0, 10)) {
                 $validatedFiles[] = $file;
             }
         }
@@ -134,7 +129,7 @@ protected function determineImageMagickVersion(): string
         // A version like 6.9.10-23
         $version = '';
         if (isset($string) && $string !== '') {
-            [, $version] = explode('Magick', $string);
+            [, $version] = explode('Magick', (string)$string);
             [$version] = explode(' ', trim($version));
             [$version] = explode('-', trim($version));
             $version = trim($version);