Repository navigation
Bugfix/duration events after start - #642
Open
hojalatheef wants to merge 5 commits into
Open
hojalatheef wants to merge 5 commits into
hojalatheef wants to merge 5 commits into
Conversation
It is not possible to take part in a duration event after it has started. As the date constraint of the list types was applied to day_time only, the next remaining day of an already started duration event was still found. The event was listed with the date of today, but sorted by sort_day_time, which contains its first day, so it was also shown on top of the list. Restrict sort_day_time to the start of the list type, too. As sort_day_time is equal to day_time for all other event types, only duration events are affected. Bump version to 10.2.13 and add ChangeLog entry.
The calendar highlighted all days of a duration event, although it is only possible to take part on its first day. Further, the list does not show a duration event for any of the following days, so clicking such a highlighted day resulted in an empty list. Only return the first day of duration events in getDaysInRange(). That is the day record where day_time equals sort_day_time.
Cover started duration events for all list types, a duration event starting today, a started duration event next to other events and the calendar click on the first and a following day of a duration event. For the calendar, cover a duration event which has started in the previous month and a duration event with a time record.
…arch Like the list types, the search applied its date constraint to day_time only and still found already started duration events with the date of their next remaining day. Move the constraint for sort_day_time into its own method and use it for the search, too.
…tings Cover a duration event starting today without recurringPast, where the list begins at the standardized "now", and started and upcoming duration events for each merge setting of the list plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.