Repository navigation
[BUGFIX] Show duration events on every day selected in calendar - #641
Closed
hojalatheef wants to merge 2 commits into
Closed
hojalatheef wants to merge 2 commits into
hojalatheef wants to merge 2 commits into
Conversation
Selecting a day in the calendar restricted only the outer day query to that day. The sub-query, which resolves the day record to display via MIN(day_time) per event and sort_day_time, was not restricted. As all days of a duration event share the same sort_day_time, the sub-query always resolved to the first day of the event, so the event was listed on its first day only. The same applied to recurring events with mergeRecurringEvents enabled. Restrict the sub-query to the selected day, too. Bump version to 10.2.13 and add ChangeLog entry.
Single events were only added to the day storage, if their event begin was strictly greater than the earliest date of the allowed time frame. With recurringPast set to 0 that date is today at midnight, so events starting today at midnight did not get a day record and were not shown in frontend. Include the earliest date of the time frame in the comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a day in the calendar restricted only the outer day query to that day. The sub-query, which resolves the day record to display via MIN(day_time) per event and sort_day_time, was not restricted. As all days of a duration event share the same sort_day_time, the sub-query always resolved to the first day of the event, so the event was listed on its first day only. The same applied to recurring events with mergeRecurringEvents enabled.
Restrict the sub-query to the selected day, too.
Bump version to 10.2.13 and add ChangeLog entry.