Repository navigation
[SECURITY] Harden event UID resolution - #637
Merged
sfroemkenjw merged 1 commit intoAug 27, 2026
Merged
Conversation
Backport of 489b934 from main (#633), RestrictAccessEventListener part only. Hardens RestrictAccessEventListener against non-scalar/malicious "event" request arguments when resolving the event UID, instead of blindly (int)-casting them. The AttachOrganizerToEventMiddleware part of the original patch does not apply here: this branch has no such middleware. Organizer assignment is handled by AddOrganizerToEventRecordEventListener, a PSR-14 listener that reads the action name from the already-dispatched Extbase request instead of the raw POST body, so the case-based action-name bypass fixed on main does not exist on this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main([SECURITY] Sanitize action name and harden event UID resolution #633) to TYPO3 10.4/11.5 -RestrictAccessEventListenerpart only.RestrictAccessEventListener::isAccessAllowed()now hardens event UID resolution against non-scalar/maliciouseventrequest arguments instead of blindly(int)-casting them.AttachOrganizerToEventMiddlewarepart of the original patch was checked but does not apply to this branch: no such middleware exists here. Organizer assignment on this branch is handled byAddOrganizerToEventRecordEventListener(PSR-14, fires after Extbase has already resolved the action name from the request), which does not read the raw$_POST['action']string the way the middleware onmain/TYPO3_12-4does - so the case-based action-name bypass (Create/CREATE) does not exist on this branch's architecture.is_array(),(int),??) are plain PHP, already-imported TYPO3 classes are unchanged - no new compatibility shim (compat_version) needed for TYPO3 10.4/11.5 or PHP 7.4+.Test plan
composer validate(PHP 7.4 and 8.0, matching the CI matrix in.github/workflows/ci.yml)composer ci:php:lint(PHP 7.4 and 8.0) - clean🤖 Generated with Claude Code