-
Notifications
You must be signed in to change notification settings - Fork 2
Add showrepr battery for short Base.show
#21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
968f10f
Add JET
91f6363
CI: drop JET on Julia 1.6 and nightly
98042a0
Fix JET 0.11 warning: always set `fieldnames`
271d2d2
Add @battery / @enumbattery: opt-in counterparts to @batteries
bfd0633
Add `showrepr` battery: heuristic short, recreatable `Base.show`
86269b5
Fix Julia 1.6 issues found by CI
20e8667
Make def_batteries JET-clean: always bind fieldnames
73d24ce
Make Aqua happy by adding a compat entry for a test dependency
9c65519
Move `showrepr` logic into separate files
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, this will also bite when running tests locally, right?
Maybe we should just have a workflow step separate from running tests that just runs JET?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is unfortunately a trade-off currently, but running the tests locally is exactly the reason why I went this route.
With the approach proposed in the current PR, you can simply run your tests locally on Julia 1.10 and 1.12 and you'll get the JET results. Note that Julia 1.10 uses an older JET version, but this is the most recent JET version which supports Julia 1.10.
You can also test on Julia 1.13 if you add the branch described in this comment to your default environment and start the test from there.
I don't know whether Julia 1.6 and JET can cooperate, as my default environment is not fully functional due to using custom registries and I didn't want to spend additional time to work around this. But I think it's unlikely that you'd learn something about useful code changes there. And CI is not worse than before the JET PR.
Julia nightly, is currently just not supported in JET.
With the separate workflow you'd get no local JET testing at all. You could surely always explicitly test it with JET, but we all know how easy it is to forget about this. With the approach from this PR all the most important Julia versions (1.10, 1.12, 1.13) can be tested locally.
It's unfortunate that the situation around JET is currently so tricky. You can follow the above link and the linked discussion therein to see that currently there does not seem to be a better solution. I don't know of a better tradeoff.