Skip to content

Allow for proposed new parsing of array[end] in Setfield#182

Merged
jw3126 merged 1 commit into
jw3126:masterfrom
mlechu:fix-end-parsing
Feb 21, 2025
Merged

Allow for proposed new parsing of array[end] in Setfield#182
jw3126 merged 1 commit into
jw3126:masterfrom
mlechu:fix-end-parsing

Conversation

@mlechu

@mlechu mlechu commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

This is essentially the same change as JuliaObjects/Accessors.jl#196. Description copied below:

To fix JuliaLang/julia#57269, a small-but-breaking AST change is needed (PR JuliaLang/julia#57368). The set macro in Setfield and Accessors breaks, and enough packages depend on this macro that it needs to be updated before deciding whether to merge the julialang PR.

This PR only recognizes the new way of parsing array[end], and should not change any behaviour when used with the current parser.

@jw3126

jw3126 commented Feb 19, 2025

Copy link
Copy Markdown
Owner

@topolarity

Copy link
Copy Markdown

The Accessors change has now merged - Anything else needed here @jw3126 ?

@jw3126
jw3126 merged commit 81d8dab into jw3126:master Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arr[var"end"] is the same as arr[end]

3 participants