Skip to content

Add unit tests for ImportService and fix relationship syncing - #20

Merged
juzaweb merged 1 commit into
masterfrom
add-import-service-test-16868347235248476432
Feb 10, 2026
Merged

Add unit tests for ImportService and fix relationship syncing#20
juzaweb merged 1 commit into
masterfrom
add-import-service-test-16868347235248476432

Conversation

@juzaweb

@juzaweb juzaweb commented Feb 10, 2026

Copy link
Copy Markdown
Owner

Added comprehensive unit tests for ImportService covering movie import, TV show import, and existing record updates. The tests revealed a bug in Movie::syncActors (and similar methods for directors/writers) where it was incorrectly querying for translated names; this has been fixed to query the main table column.


PR created automatically by Jules for task 16868347235248476432 started by @juzaweb

- Created `tests/Unit/ImportServiceTest.php` to test importing movies, TV shows, and updates.
- Added `TestImportService` helper class to mock `Tmdb` service and bypass `MediaUploader`.
- Fixed `Movie::syncActors`, `Movie::syncDirectors`, and `Movie::syncWriters` to query `name` directly instead of using `whereTranslation`, as these models do not translate the `name` attribute.

Co-authored-by: juzaweb <47020363+juzaweb@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@juzaweb
juzaweb merged commit 8fa65da into master Feb 10, 2026
2 checks passed
@juzaweb
juzaweb deleted the add-import-service-test-16868347235248476432 branch February 10, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant