Skip to content

refactor: atoms/SfHeading and utility classes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justyna-13 wants to merge 5 commits into
base: refactor/style-guide
Choose a base branch
from
Open

refactor: atoms/SfHeading and utility classes #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0e0b61
wip: classes added
Jul 7, 2020
3607e21
Merge branch 'refactor/style-guide' into refactor/atoms-heading
Jul 8, 2020
bc2c617
refactor: classes added
Jul 8, 2020
bcc316d
refactor: classes added
Jul 8, 2020
e578b0f
Merge branch 'refactor/style-guide' into refactor/atoms-heading
Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 2 additions & 43 deletions packages/shared/styles/components/atoms/SfHeading.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,13 @@
@import "../../helpers";
.sf-heading {
box-sizing: border-box;
padding: var(--heading-padding, 0 0 var(--spacer-xs) 0);
text-align: var(--heading-text-align, center);
&__title {
margin: var(--heading-title-margin, 0);
color: var(--heading-title-color, var(--c-text));
@include font(
--heading-title-font,
var(--font-semibold),
var(--h1-font-size),
1.6,
var(--font-family-secondary)
);
&--h2 {
font-size: var(--heading-title-font-size, var(--h2-font-size));
font-weight: var(--heading-title-font-weight, var(--font-normal));
}
&--h3 {
font-size: var(--heading-title-font-size, var(--h3-font-size));
font-weight: var(--heading-title-font-weight, var(--font-medium));
}
&--h4 {
font-size: var(--heading-title-font-size, var(--h4-font-size));
font-weight: var(--heading-title-font-weight, var(--font-normal));
}
&--h5 {
font-size: var(--heading-title-font-size, var(--h5-font-size));
font-weight: var(--heading-title-font-weight, var(--font-bold));
}
&--h6 {
font-size: var(--heading-title-font-size, var(--h6-font-size));
font-weight: var(--heading-title-font-weight, var(--font-normal));
}
font-weight: var(--font-normal);
}
&__subtitle {
margin: var(--heading-subtitle-margin);
color: var(--heading-subtitle-color, var(--c-text));
@include font(
--heading-subtitle-font,
var(--font-light),
var(--font-xs),
1.6,
var(--font-family-secondary)
);
}
@include for-desktop {
--heading-padding: 0;
--heading-border: 0;
--heading-text-align: center;
font-weight: var(--font-light);
}
&--underline {
@include border(--heading-border, 0 0 1px 0, solid, var(--c-light));
Expand Down
9 changes: 6 additions & 3 deletions packages/vue/src/components/atoms/SfHeading/SfHeading.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
<template>
<header class="sf-heading">
<header class="sf-heading pdbxs--s">
<!--@slot Heading title. Slot content will replace default <h> tag-->
<slot name="title" v-bind="{ title }">
<component
:is="`h${level}`"
class="sf-heading__title"
class="sf-heading__title h1"
:class="level > 1 && `sf-heading__title--h${level}`"
>
{{ title }}
</component>
</slot>
<!--@slot Heading subtitle. Slot content will replace default <div> tag-->
<slot name="subtitle" v-bind="{ subtitle }">
<div v-if="hasSubtitle" class="sf-heading__subtitle">
<div
v-if="hasSubtitle"
class="sf-heading__subtitle font-secondary txt-xs pt"
>
{{ subtitle }}
</div>
</slot>
Expand Down