fix: TUI follow-up spinner and isolated probe clipboard (#845, #836) - #854
Draft
justrach wants to merge 5 commits into
Draft
fix: TUI follow-up spinner and isolated probe clipboard (#845, #836)#854justrach wants to merge 5 commits into
justrach wants to merge 5 commits into
Conversation
…oards #845: the line-REPL spinner kept skipping frames whenever a steer row was visible, so composing a follow-up froze the thinking indicator. Draw the spinner on the line above the input (DECSC/DECRC) and serialize those writes with steer echo. Term-driven TUI tests lock the same contract for the pager: typing and Enter queue a follow-up without cancelling or freezing the pending blink. #836: tuiguard now mints per-probe copy/paste commands that Graff children inherit via GRAFF_CLIPBOARD_COPY/PASTE, so parallel probes no longer share the host pasteboard. Direct probe runs keep native pbcopy/pbpaste.
Zig 0.17 has no std.posix.getenv. Use the same std.c.getenv path the TUI already uses for TERM/TMUX, and drop a pointless job discard.
…gone run_probe deletes the per-probe wrappers in finally, so isfile after return was a false failure of the inherit check.
libc getenv and a second Threaded Io never reached the probe copy script, so drag-select still wrote the host pasteboard (#836).
finish() always prunes, and iterating a non-iterate tmpDir fd is EBADF on this host. Same openDir flag the retention test uses.
|
Take yxlyx first on the overlapping bits of this draft:
Keep this PR for #845 (TUI follow-up spinner) after those land and we rebase. |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #845 and #836.
spinnerTaskkeeps frames while the steer row is visible, hopping one line with DECSC/DECRC so the input is not wiped.GRAFF_CLIPBOARD_COPY/PASTEso parallel clipboard tests do not collide.Also unblocks Linux
zig build test: the cancel-file unit test now iterates its tmpDir (same flag as the retention test).Branch is off latest
main. Tier 1 green, including 19 tuiguard PTY probes.