Fix missing titles on existing GUI conversations - #852
Open
yxlyx wants to merge 1 commit into
Open
Conversation
Structured user text was omitted from the saved-title fallback, leaving active chats labeled Untitled session. Read both text forms, skip empty and injected content, and discard stale placeholders on resume. Recover legacy GUI titles without rewriting saved conversations or replacing named titles. Bound legacy reads and invalidate cached recovery when the file changes. Cover persistence, malformed content, Unicode boundaries, cache rewrites, and list/read consistency with regression tests.
This was referenced Sep 10, 2026
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Existing conversations could be saved as "Untitled session" because the title fallback ignored structured user text. Correcting persistence prevents new occurrences; display-time recovery repairs existing entries without rewriting conversations or replacing named titles. Legacy reads remain bounded, and malformed or oversized files retain their saved fallback.
Verification
Desktop unit tests and production build passed. The complete tier-1 pre-push checks passed.
Fixes #830.