Skip to content

release: migrate legacy Qwen sidecars to Jina - #741

Merged
justrach merged 1 commit into
mainfrom
release/0.2.5852
Sep 1, 2026
Merged

justrach merged 1 commit into
mainfrom
release/0.2.5852

Conversation

@justrach

@justrach justrach commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • recognize only the exact legacy hosted-Qwen 512D sidecar
  • serve the triggering hybrid request through bounded exact Jina reranking,
    then schedule one background rebuild
  • keep the old OpenPuffer generation until the Jina replacement validates and
    commits atomically
  • join the migration worker before project-cache eviction or shutdown
  • preserve custom-provider, Windows, sensitive-path, and no-CPU-fallback
    boundaries
  • document the opt-out: CODEDB_NO_AUTO_SEMANTIC_MIGRATION=1
  • bump release metadata to 0.2.5852

Verification

  • zig build test
  • zig build test-ann
  • zig build test-semantic-index
  • vendored OpenPuffer zig build test (recall@10 = 1.000)
  • MCP E2E: 76/76
  • ReleaseFast cross-builds: macOS x86_64, Linux x86_64/aarch64, Windows x86_64
  • production-backed smoke: legacy Qwen sidecar → first exact Jina result →
    1.52s background rebuild → next query ann_applied through mmap OpenPuffer

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T04:49:34.400146Z b72db9b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b72db9bcf6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/mcp.zig
Comment on lines +4459 to +4463
switch (semantic_index_mod.scheduleLegacyHostedMigration(
io,
cache,
explorer,
store,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Disclose automatic migration in the MCP tool schema

When a hybrid MCP query encounters a legacy Qwen sidecar, this call now starts a repository-wide background embedding build, but the codedb_context schema at src/mcp.zig:701 still says the ANN is explicitly built and that a missing or stale sidecar only sends bounded reranking candidates. Clients relying on tools/list therefore are not informed that an ordinary query can transmit all indexable code chunks; update the tool description to disclose the narrow migration and opt-out.

AGENTS.md reference: AGENTS.md:L5-L12

Useful? React with 👍 / 👎.

Comment thread src/mcp.zig
Comment on lines +4467 to +4468
.scheduled => retrieval.detail = "AnnSidecarMigrationScheduled",
.in_progress => retrieval.detail = "AnnSidecarMigrationInProgress",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve fallback failures when reporting migration status

If exact Jina reranking fails for a legacy sidecar, the handler first records the provider error at lines 4442-4444, but a successfully scheduled migration overwrites that diagnostic here while leaving retrieval.semantic as unavailable. The structured response then reports only AnnSidecarMigrationScheduled, hiding the reason retrieval failed; migration status needs a separate field or must not replace the failure detail.

Useful? React with 👍 / 👎.

@justrach
justrach merged commit 74c2e20 into main Sep 1, 2026
4 checks passed
@justrach
justrach deleted the release/0.2.5852 branch September 1, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant