release: migrate legacy Qwen sidecars to Jina - #741
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b72db9bcf6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| switch (semantic_index_mod.scheduleLegacyHostedMigration( | ||
| io, | ||
| cache, | ||
| explorer, | ||
| store, |
There was a problem hiding this comment.
Disclose automatic migration in the MCP tool schema
When a hybrid MCP query encounters a legacy Qwen sidecar, this call now starts a repository-wide background embedding build, but the codedb_context schema at src/mcp.zig:701 still says the ANN is explicitly built and that a missing or stale sidecar only sends bounded reranking candidates. Clients relying on tools/list therefore are not informed that an ordinary query can transmit all indexable code chunks; update the tool description to disclose the narrow migration and opt-out.
AGENTS.md reference: AGENTS.md:L5-L12
Useful? React with 👍 / 👎.
| .scheduled => retrieval.detail = "AnnSidecarMigrationScheduled", | ||
| .in_progress => retrieval.detail = "AnnSidecarMigrationInProgress", |
There was a problem hiding this comment.
Preserve fallback failures when reporting migration status
If exact Jina reranking fails for a legacy sidecar, the handler first records the provider error at lines 4442-4444, but a successfully scheduled migration overwrites that diagnostic here while leaving retrieval.semantic as unavailable. The structured response then reports only AnnSidecarMigrationScheduled, hiding the reason retrieval failed; migration status needs a separate field or must not replace the failure detail.
Useful? React with 👍 / 👎.
Summary
then schedule one background rebuild
commits atomically
boundaries
CODEDB_NO_AUTO_SEMANTIC_MIGRATION=1Verification
zig build testzig build test-annzig build test-semantic-indexzig build test(recall@10 = 1.000)1.52s background rebuild → next query
ann_appliedthrough mmap OpenPuffer