Skip to content

fix(address): accept hex TRON addresses in resolveAddress - #28

Closed
piyushbag wants to merge 1 commit into
justlend:mainfrom
piyushbag:fix/tron-address-validation
Closed

fix(address): accept hex TRON addresses in resolveAddress#28
piyushbag wants to merge 1 commit into
justlend:mainfrom
piyushbag:fix/tron-address-validation

Conversation

@piyushbag

Copy link
Copy Markdown
Contributor

Problem

No open maintainer issues in mcp-server-justlend. resolveAddress rejected valid hex-encoded TRON addresses even though other helpers accept both encodings.

Approach

  • Add isValidTronAddress (Base58 or hex).
  • Use it in resolveAddress.
  • Add unit tests for hex acceptance and addressesEqual.

Test plan

  • npm test -- tests/core/services/address.test.ts (21 passed)

FALLBACK: no maintainer-authored issues; TRON stack fix in the JustLend org.

Add isValidTronAddress helper and tests so MCP callers can pass either
Base58 or 41/0x hex encodings.
@BlackChar92

Copy link
Copy Markdown
Contributor

Thanks for the contribution! This exact change was included in #26 as commit 540e769 and has now been merged into main. Your authorship is preserved on the commit.

Since the fix and its tests are already present, we’ll close this PR as superseded by #26. Appreciate the clear implementation and test coverage!

@piyushbag

Copy link
Copy Markdown
Contributor Author

Thanks for the update. The same fix is already present on #26 as commit 540e769, so I'm closing this PR as superseded. Happy to help with anything else on address resolution if useful.

@piyushbag piyushbag closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants