fix(address): accept hex TRON addresses in resolveAddress - #28
Closed
piyushbag wants to merge 1 commit into
Closed
Conversation
Add isValidTronAddress helper and tests so MCP callers can pass either Base58 or 41/0x hex encodings.
Contributor
|
Thanks for the contribution! This exact change was included in #26 as commit 540e769 and has now been merged into main. Your authorship is preserved on the commit. Since the fix and its tests are already present, we’ll close this PR as superseded by #26. Appreciate the clear implementation and test coverage! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No open maintainer issues in mcp-server-justlend.
resolveAddressrejected valid hex-encoded TRON addresses even though other helpers accept both encodings.Approach
isValidTronAddress(Base58 or hex).resolveAddress.addressesEqual.Test plan
npm test -- tests/core/services/address.test.ts(21 passed)FALLBACK: no maintainer-authored issues; TRON stack fix in the JustLend org.