Repository navigation
fix(security): turn off the UAP routes by default - #1452
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns off the
/uap/*routes by default, for security. A new flag,UAP_ROUTES_ENABLED, controls them. It followsMCP_PUBLIC_ENDPOINT_ENABLED.Deployments need no change. If the variable is unset, the routes are off.
Why
Nobody uses UAP today, and the routes have these problems:
What this does not fix
The bugs stay in the code. Fix them before setting
UAP_ROUTES_ENABLED=true. The flag comment inapp/core/config/static.pylists them.Security findings: BK-17 and BK-18 are mitigated, not fixed.
While the routes are off,
/uap/webhookreturns 404. Theuapcredential row and any active mandates at Juspay stay in place.Changes
app/core/config/static.pyapp/api/routers/breeze_buddy/__init__.pyCLAUDE.mdtests/test_api_docs_disabled.py/uap/route is served by defaultTesting
/uaproutes.true: 149 paths, all 9/uaproutes return.tests/crmand the UAP, credential, and docs tests pass: 1664 passed, 15 skipped.google.cloud.kmsand test JWT values. No server or database ran.CI runs only
tests/crm, so it does not run the new test.