Repository navigation
perf(chat): create the Gemini prompt cache in the background - #1450
Open
raghvendradhakar wants to merge 1 commit into
Open
raghvendradhakar wants to merge 1 commit into
raghvendradhakar wants to merge 1 commit into
Conversation
On a cache miss, resolve_prompt_cache awaited caches.create inline under one global lock, so the first message per pod, template and hour waited 2.7-3.9 s for Vertex to build the cache, and other templates queued behind it. A miss now returns None (the caller already sends the full prefix, which is as fast as a cached request at these sizes) and creates the cache in a background task, one per key. An entry inside the refresh margin is still served while its replacement is created, and is no longer served in its last 60 s. A failed create still cools down for 600 s, but no longer stops a live cache from being served.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a cache miss, resolve_prompt_cache awaited caches.create inline under one global lock, so the first message per pod, template and hour waited 2.7-3.9 s for Vertex to build the cache, and other templates queued behind it.
A miss now returns None (the caller already sends the full prefix, which is as fast as a cached request at these sizes) and creates the cache in a background task, one per key. An entry inside the refresh margin is still served while its replacement is created, and is no longer served in its last 60 s. A failed create still cools down for 600 s, but no longer stops a live cache from being served.