Cloudflare-based PR Preview - #873
Closed
jasongrout wants to merge 6 commits into
Closed
Conversation
Carreau
approved these changes
Jul 31, 2026
Collaborator
|
My suggestion would be to use either netlify or read the docs over cloudflare, just to avoid having yet another way of hosting PR previews within the jupyter ecosystem, but if you want to go with this approach it seems fine to me as well |
This would clutter up the main repo's deployment listing with pr previews. We can just rely on the comment in PRs.
Member
Author
|
I think it's not worth pursuing this. I've updated the top-level comment with my thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This experiments with a cloudflare-based PR preview mechanism as an attempt to resolve #768
Findings:
Overall, I think cloudflare previews are too complicated to pursue at this time. If their GitHub app supported generating pr previews from forks, and they introduced an automatic retention limit, I think it would be worth reconsidering.
Claude Fable 5 helped with this PR.