Skip to content

test(zsh): check capture for fzf exit status in widget - #4872

Merged
junegunn merged 2 commits into
masterfrom
propagated
Jul 27, 2026
Merged

test(zsh): check capture for fzf exit status in widget#4872
junegunn merged 2 commits into
masterfrom
propagated

Conversation

@LangLangBart

Copy link
Copy Markdown
Collaborator

fix #4871

  • first add a regression test => let it run to see only perl fails
  • commit the suggested fix

Contribution Policy

We do not accept pull requests generated primarily by AI without genuine understanding or real-world usage context.

All contributions are expected to demonstrate:

  • A clear understanding of the codebase
  • Alignment with product direction
  • Thoughtful reasoning behind changes
  • Evidence of real-world usage or hands-on experience with the problem

If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.


Acknowledgement

  • I confirm that this PR meets the above expectations and reflects my own understanding and real-world context.

@LangLangBart
LangLangBart requested a review from junegunn as a code owner July 27, 2026 03:30
@github-actions github-actions Bot added the test Tests label Jul 27, 2026
@github-actions github-actions Bot added shell Shell scripts zsh Zsh labels Jul 27, 2026
@junegunn
junegunn requested a review from Copilot July 27, 2026 05:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@junegunn junegunn left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this. Confirmed the test fails without the patch but passes with it.

@junegunn
junegunn merged commit 2327221 into master Jul 27, 2026
6 checks passed
@LangLangBart
LangLangBart deleted the propagated branch July 31, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shell Shell scripts test Tests zsh Zsh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fzf-history-widget ignores fzf exit status when Perl is available

3 participants