Resolve typecheck issues in monorepo and CI pipeline - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves two key TypeScript compilation errors that were failing the CI/CD pipeline in the
Typecheckjob.Problems Identified
tsc) was failing with the errorCannot find type definition file for 'node'. This occurred because"types": ["node"]is declared in the compiler options of workspace packages (likelocket- apiandplayground), but@types/nodewas missing from the project dependencies.playgroundapp depends on thelocket-apiworkspace package. When typechecking the playground,tscexpects the type declarations forlocket-api(located in itsdist/directory) to be generated. However, the CI workflow only built the repository during theTestmatrix job, leaving theTypecheckjob without compiled packages.Solutions Implemented
@types/nodeto the rootpackage.jsondevDependencies and updated the lockfile (bun.lock) so Node. js type definitions are globally available in the monorepo.Buildstep conditional in.github/workflows/code-quality.ymlto build the workspace packages for any matrix job that is notLint(i.e.TestandTypecheck)