Skip to content

Resolve typecheck issues in monorepo and CI pipeline - #3

Merged
jumpogpo merged 2 commits into
jumpogpo:mainfrom
PunGrumpy:main
May 28, 2026
Merged

Resolve typecheck issues in monorepo and CI pipeline#3
jumpogpo merged 2 commits into
jumpogpo:mainfrom
PunGrumpy:main

Conversation

@PunGrumpy

Copy link
Copy Markdown
Contributor

This pull request resolves two key TypeScript compilation errors that were failing the CI/CD pipeline in the Typecheck job.

Problems Identified

  1. Missing Node Types: The typechecking compiler (tsc) was failing with the error Cannot find type definition file for 'node'. This occurred because "types": ["node"] is declared in the compiler options of workspace packages (like locket- api and playground), but @types/node was missing from the project dependencies.
  2. Missing Workspace Dependency Build: The playground app depends on the locket-api workspace package. When typechecking the playground, tsc expects the type declarations for locket-api (located in its dist/ directory) to be generated. However, the CI workflow only built the repository during the Test matrix job, leaving the Typecheck job without compiled packages.

Solutions Implemented

  1. Added Workspace DevDependency: Added @types/node to the root package.json devDependencies and updated the lockfile (bun.lock) so Node. js type definitions are globally available in the monorepo.
  2. Updated CI Workflow: Modified the Build step conditional in .github/workflows/code-quality.yml to build the workspace packages for any matrix job that is not Lint (i.e. Test and Typecheck)

@jumpogpo
jumpogpo merged commit 52b2cac into jumpogpo:main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants