Skip to content

Use isone #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 6 commits into from
Apr 22, 2026
Merged

Use isone #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6cee46
Use isone
blegat Apr 14, 2025
d6e55ac
Fix format
blegat Apr 20, 2026
631a307
dev
blegat Apr 22, 2026
89c25ae
Add test
blegat Apr 22, 2026
07e9f37
Add test
blegat Apr 22, 2026
b935388
Revert "dev"
blegat Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Bridges/Variable/kernel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,12 @@ function MOI.Bridges.Variable.bridge_constrained_variable(
gram, vars, con = SOS.add_gram_matrix(model, M, gram_basis, T)
push!(variables, vars)
push!(constraints, con)
MA.operate_to!(cache, +, gram)
MA.operate!(SA.UnsafeAddMul(*), acc, cache, weight)
if isone(weight)
MA.operate!(SA.UnsafeAdd(), acc, gram)
else
MA.operate_to!(cache, +, gram)
MA.operate!(SA.UnsafeAddMul(*), acc, cache, weight)
end
end
MA.operate!(SA.canonical, SA.coeffs(acc))
return KernelBridge{T,M}(
Expand Down
22 changes: 16 additions & 6 deletions src/Certificate/ideal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,22 @@ function _combine_with_gram(
)
end
for (gram, weight) in zip(gram_bases, weights)
MA.operate_to!(
cache,
+,
GramMatrix{_NonZero}((_, _) -> _NonZero(), gram),
)
MA.operate!(SA.UnsafeAddMul(*), p, cache, weight)
if isone(weight)
MA.operate!(
SA.UnsafeAdd(),
p,
SA.QuadraticForm(
GramMatrix{_NonZero}((_, _) -> _NonZero(), gram),
),
)
else
MA.operate_to!(
cache,
+,
GramMatrix{_NonZero}((_, _) -> _NonZero(), gram),
)
MA.operate!(SA.UnsafeAddMul(*), p, cache, weight)
end
end
MA.operate!(SA.canonical, SA.coeffs(p))
return SA.sub_basis(parent(basis), keys(SA.coeffs(p)))
Expand Down
99 changes: 99 additions & 0 deletions test/Bridges/Variable/kernel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,105 @@ function test_runtests()
return
end

function test_runtests_weighted()
@polyvar x y
MOI.Bridges.runtests(
SumOfSquares.Bridges.Variable.KernelBridge,
model -> begin
p, _ = MOI.add_constrained_variables(
model,
SumOfSquares.WeightedSOSCone{
MOI.PositiveSemidefiniteConeTriangle,
}(
MB.SubBasis{MB.Monomial}([
y^4,
x * y^3,
x^2 * y^2,
x^3 * y,
x^4,
]),
[MB.SubBasis{MB.Monomial}([y^2, x * y, x^2])],
[MB.algebra_element(2.0 * x^0 * y^0)],
),
)
a = float.(1:length(p))
MOI.add_constraint(
model,
MOI.Utilities.vectorize([a' * p]),
MOI.Zeros(1),
)
end,
model -> begin
q, _ = MOI.add_constrained_variables(
model,
MOI.PositiveSemidefiniteConeTriangle(3),
)
a = float.(1:length(q))
MOI.add_constraint(
model,
MOI.Utilities.vectorize([
2.0 * q[1] +
8.0 * q[2] +
6.0 * (1.0q[3] + 2.0q[4]) +
16.0 * q[5] +
10.0 * q[6],
]),
MOI.Zeros(1),
)
end;
cannot_unbridge = true,
)
return
end

# weight (1 + x), gram basis [1, x]
# (1 + x) * (Q11 + 2*Q12*x + Q22*x^2)
# = Q11 + (2*Q12 + Q11)*x + (Q22 + 2*Q12)*x^2 + Q22*x^3
function test_runtests_polynomial_weight()
@polyvar x
MOI.Bridges.runtests(
SumOfSquares.Bridges.Variable.KernelBridge,
model -> begin
p, _ = MOI.add_constrained_variables(
model,
SumOfSquares.WeightedSOSCone{
MOI.PositiveSemidefiniteConeTriangle,
}(
MB.SubBasis{MB.Monomial}([x^0, x, x^2, x^3]),
[MB.SubBasis{MB.Monomial}([x^0, x])],
[MB.algebra_element(1.0 * x^0 + 1.0 * x)],
),
)
a = float.(1:length(p))
MOI.add_constraint(
model,
MOI.Utilities.vectorize([a' * p]),
MOI.Zeros(1),
)
end,
model -> begin
q, _ = MOI.add_constrained_variables(
model,
SumOfSquares.PositiveSemidefinite2x2ConeTriangle(),
)
# p[1] = 1.0*q[1], p[2] = 1.0*q[1] + 2.0*q[2],
# p[3] = 2.0*q[2] + 1.0*q[3], p[4] = 1.0*q[3]
MOI.add_constraint(
model,
MOI.Utilities.vectorize([
1.0 * q[1] +
2.0 * (1.0q[1] + 2.0q[2]) +
3.0 * (2.0q[2] + 1.0q[3]) +
4.0 * q[3],
]),
MOI.Zeros(1),
)
end;
cannot_unbridge = true,
)
return
end

end # module

TestVariableKernel.runtests()
Loading