1.0.0 release candidate (breaking API changes) containing wide-ranging fixes and improvements - #1
Open
desophos wants to merge 30 commits into
Open
1.0.0 release candidate (breaking API changes) containing wide-ranging fixes and improvements#1desophos wants to merge 30 commits into
desophos wants to merge 30 commits into
Conversation
Also add a better error message and request retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I tried to use pokeapi-scala and discovered that some of the models were inaccurate. I decided to add tests to check all the PokeAPI data and got a little carried away in my quest to make the API simpler and more flexible -- I hope you don't mind the refactoring. I've added myself as a developer in build.sbt and the license file since I changed nearly everything except the models. I need to use this library in my own project, so I hope you can accept and publish these changes as version 1.0.0 (due to the breaking API changes). I'm open to discussion about any of my changes; I just want to improve this library, so I'm happy to incorporate your feedback. Thanks for your time.