fix(types): lowercase reversed and alternate in WAAPIAnimationOptions - #1185
Open
Hashim1999164 wants to merge 1 commit into
Open
fix(types): lowercase reversed and alternate in WAAPIAnimationOptions#1185Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
…ions Matches the runtime WAAPI params and other typedefs so TypeScript/IDE hints suggest the properties that actually work. Fixes juliangarnier#1113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WAAPIAnimationOptions(Reversed/Alternate->reversed/alternate).dist/modules/types/index.d.tsso TypeScript matches runtime.src/waapi/waapi.jsalready readsparams.reversedandparams.alternate. The uppercase names caused IDE/TS suggestions that silently fail at runtime. Other typedefs already use lowercase.Fixes #1113
Test plan
WAAPIAnimationOptionsindist/modules/types/index.d.tsexposesreversedandalternatesrc/types/index.jsmatcheswaapi.animate(..., { reversed: true, alternate: true })still works as before