Skip to content

Make sonic-bfb-installer reset dpus synchronously. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
judsonwilson-nvidia wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Make sonic-bfb-installer reset dpus synchronously. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions platform/mellanox/sonic-bfb-installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,10 @@ bfb_install_call() {
cat "$result_file"
fi

# Stop rshim application and reset DPU
# Stop rshim application.
stop_rshim_daemon "$rid"
log_info "$rid: Resetting DPU $dpu"

reset_dpu "$dpu" "$verbose"
# The dpu will be reset in a later step.
}

file_cleanup(){
Expand Down Expand Up @@ -605,7 +604,7 @@ main() {
validate_config_files "${sorted_devs[@]}" "${arr[@]}"
fi

# Install BFB on each device
# Install BFB on each device (in parallel)
trap 'kill_ch_procs' SIGINT SIGTERM SIGHUP

for i in "${!sorted_devs[@]}"; do
Expand All @@ -614,6 +613,17 @@ main() {
bfb_install_call "$rshim_name" "$dpu_name" "$EXTRACTED_BFB_PATH" "${arr[$i]}" &
done
wait

# Reset DPUs.
# Done one-by-one to avoid PCI race conditions.
for i in "${!sorted_devs[@]}"; do
rshim_name=${sorted_devs[$i]}
rid=${rshim_name#rshim}
dpu_name=${rshim2dpu[$rshim_name]}
log_info "$rid: Resetting DPU $dpu_name"
reset_dpu "$dpu_name" "$verbose"
done
log_info "Done resetting DPUs"
}

# Helper function to parse command line arguments
Expand Down