Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci-gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
dependency_review:
name: Dependency Review
needs: classify
if: github.event_name == 'pull_request' && needs.classify.outputs.dependency_review == 'true'
if: needs.classify.outputs.dependency_review == 'true'
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -103,6 +103,7 @@ jobs:
version: "0.10.9"
enable-cache: true
- uses: actions/dependency-review-action@a1d282b36b6f3519aa1f3fc636f609c47dddb294 # v5.0.0
if: github.event_name == 'pull_request'
continue-on-error: true
- name: Audit resolved Python dependencies
run: uv run python3 ./tests/scripts/ci_gate.py run-dependency-audit --repo-root .
Expand Down
9 changes: 4 additions & 5 deletions tests/suites/contracts/repo/test_ci_workflow_surfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,25 +156,23 @@ def test_ci_gate_workflow_runs_on_pull_requests_main_push_and_emits_verdict() ->


def test_ci_gate_dependency_review_is_blocking_and_path_selected() -> None:
"""Dependency review should block dependency PRs with vulnerable lock output."""
"""Dependency review should block dependency changes on PRs and main pushes."""
workflow = yaml.safe_load(_workflow_text("ci-gate.yml"))
jobs = cast(dict[str, object], workflow["jobs"])
dependency_review = cast(dict[str, object], jobs["dependency_review"])
dependency_review_steps = cast(list[dict[str, object]], dependency_review["steps"])
filters_text = _ci_gate_filters_text()

assert dependency_review["name"] == "Dependency Review"
assert (
dependency_review["if"]
== "github.event_name == 'pull_request' && needs.classify.outputs.dependency_review == 'true'"
)
assert dependency_review["if"] == "needs.classify.outputs.dependency_review == 'true'"
assert dependency_review["permissions"] == {
"contents": "read",
"pull-requests": "read",
}
assert any(
step.get("uses")
== "actions/dependency-review-action@a1d282b36b6f3519aa1f3fc636f609c47dddb294"
and step.get("if") == "github.event_name == 'pull_request'"
and step.get("continue-on-error") is True
for step in dependency_review_steps
)
Expand All @@ -185,6 +183,7 @@ def test_ci_gate_dependency_review_is_blocking_and_path_selected() -> None:
assert any(
str(step.get("run", ""))
== "uv run python3 ./tests/scripts/ci_gate.py run-dependency-audit --repo-root ."
and step.get("if") is None
for step in dependency_review_steps
)
assert "dependency_review:" in filters_text
Expand Down
Loading