Vendor prebuilt multiplayer bundles so both experiments actually run - #1
Open
htsukamoto5 wants to merge 2 commits into
Open
Vendor prebuilt multiplayer bundles so both experiments actually run#1htsukamoto5 wants to merge 2 commits into
htsukamoto5 wants to merge 2 commits into
Conversation
The @jspsych-multiplayer packages cannot currently be loaded from npm: plugin-multiplayer-reference-game is unpublished (404), and the published 0.1.0 builds of the local adapter, sync and role plugins predate the jsPsych.multiplayer namespace migration, so they are incompatible with the #3694 preview core these experiments pin. Vendor all four browser bundles (built from jspsych-multiplayer@69c0d7b) so both experiment files load from a plain URL with no build step. See vendor/README.md for provenance and removal steps once PR #35 publishes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Repin the four @jspsych-multiplayer script tags in both experiment files from npm (unpublished / pre-migration) to the SHA-pinned vendor/ bundles added in the previous commit, and replace the stale "pin to a real published version" TODO with the actual situation. Both files now load with no build step and no 404s. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Neither experiment file could load. The
@jspsych-multiplayerscript tags pointed at npm, where:plugin-multiplayer-reference-gameadapter-multiplayer-local0.1.0, but pre-namespace-migrationplugin-multiplayer-sync0.1.0, but pre-namespace-migrationplugin-multiplayer-role0.1.0, but pre-namespace-migrationBoth files pin jsPsych core to the #3694 preview build, which moved the multiplayer API to the
jsPsych.multiplayernamespace. The published0.1.0bundles predate that and still call the old core API (verified:plugin-multiplayer-sync@0.1.0callspluginAPI.wait), so they are incompatible with the pinned core.Change
Vendor all four browser bundles into
vendor/and load them over jsDelivr, SHA-pinned.All four are vendored, not just the 404ing one — pinning only
reference-gamewould have traded a visible 404 for a subtler runtime failure against the migrated core.npm run buildfromjspsych/jspsych-multiplayer@69c0d7bvendor/README.mddocuments provenance and the teardown stepsTODO: pin to a real published versioncomment with the actual situationVerification
Please merge with a merge commit (not squash, not rebase).
The
<script>tags are pinned to5046bf0, the commit that addsvendor/. Squash and rebase both rewrite commit SHAs, which would orphan that commit and can break the jsDelivr URLs. A merge commit preserves it.If it does get squashed, the fix is a follow-up PR re-pinning both HTML files to the new
mainSHA.Teardown
This whole directory is temporary. Once jspsych-multiplayer#35 (Version Packages) merges and republishes, repoint the tags to
cdn.jsdelivr.net/npm/...and deletevendor/.