feat: shared-drive support, navigable picker, contrast fix for gdrive folders - #157
Merged
Conversation
ViewId.FOLDERS renders every folder in one flat list with no hierarchy. Switch to a DOCS view rooted at My Drive (setParent "root") with folder- only mimeTypes, which gives a navigable tree + breadcrumb path so the user can see where a folder lives and drill down, while still only seeing and selecting folders. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Picker: add a Shared Drives view (setEnableDrives) alongside the My Drive tree and enable the SUPPORT_DRIVES feature, so folders in shared/team drives are browsable and selectable. - gdrive.ts: pass supportsAllDrives=true on every Drive API call, plus includeItemsFromAllDrives=true on the list/query calls -- without these, a shared-drive folder is invisible to queries and unwritable on the server. Harmless no-ops for My Drive. - new.js: give the "Choose Drive folder" button colorPalette brandTeal so it reads clearly against the background instead of near-invisible gray. Tests updated (picker mock, strict-URL unit assertions). Verified: build clean, 32 unit/front-end + 14 emulator tests green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #156, refining the Google Drive folder picker.
Changes
setEnableDrives+SUPPORT_DRIVES), and everygdrive.tsDrive API call now passessupportsAllDrives=true(+includeItemsFromAllDrives=trueon queries) so shared-drive folders are visible to queries and writable server-side. Harmless no-ops for My Drive.colorPalette="brandTeal"(was near-invisible gray).Folder path — decided against
Displaying the selected folder's full path in-app would require reading ancestor folders, which
drive.fileblocks (returns 404 on un-granted ancestors). Reconstructing it would mean a restricted scope (drive.readonly) + Google verification + annual CASA assessment — not worth it for a label. The navigable picker already shows the path while choosing; we display the folder name. Scope staysdrive.file.Tests
Build clean; 32 unit/front-end + 14 emulator tests green (picker mock + strict-URL unit assertions updated to the new params, none weakened).
supportsAllDrivesparams — same server-write linchpin as My Drive, one level further.🤖 Generated with Claude Code